If your iPhone storage is full and you use High Efficiency photos, check one setting before you buy more iCloud space.
When you transfer pictures to a computer, iOS can keep a normal copy as well as the efficient one. That second copy sits on the phone and eats space you cannot see in the camera roll.
On the iPhone, open Settings, then Camera, then Formats. If High Efficiency is on, look for the transfer option on the Mac or PC side when you import, and leave the extra normal-photo copy switched off if you do not need both. The exact label moves between iOS versions. One copy of each photo is enough.
If the phone is already too full to update, or the camera has stopped saving pictures, bring it into Fonetech Lancaster. A tired battery or a failing storage chip is a different problem from a setting, and we will tell you which it is.